Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix quote on LBSGD docs #13975

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Conversation

ThomasDelteil
Copy link
Contributor

@ThomasDelteil ThomasDelteil commented Jan 23, 2019

Description

fix doc in #12171

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sandeep-krishnamurthy
Copy link
Contributor

@ThomasDelteil - Thanks for fixing this
Can you please paste a snapshot of doc with this change?

@sandeep-krishnamurthy sandeep-krishnamurthy added Doc pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 25, 2019
@szha
Copy link
Member

szha commented Feb 1, 2019

This comment is ignored: #12171 (comment)

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [Doc, pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 5, 2019
@Roshrini
Copy link
Member

Roshrini commented Feb 6, 2019

@ThomasDelteil The issue mentioned #12171 talks about doc fix needed and the bug in optimizer. This PR only takes care of doc fix.
Can you remove "fix #12171" from description or maybe fix the bug as well to merge this PR and close the issue?

@ankkhedia
Copy link
Contributor

@ThomasDelteil Could you please take a look into comments by @Roshrini

@eric-haibin-lin eric-haibin-lin merged commit 0e08891 into apache:master Feb 15, 2019
@eric-haibin-lin
Copy link
Member

I've updated the description. The issue is left open.

stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* change docs lbsgd

* fix more
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
* change docs lbsgd

* fix more
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
* change docs lbsgd

* fix more
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* change docs lbsgd

* fix more
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* change docs lbsgd

* fix more
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants